[MINC-development] miset_apparent_record_dimension_flag() seemingly broken, 2nd paramater unused?

[Vladimir S. FONOV]

Looks like it is something that was programmed about 10 years ago:
https://github.com/BIC-MNI/libminc/blame/develop/libsrc2/dimension.c#L639

And not being used in any of the minc tools that I know about ( 
https://github.com/BIC-MNI/minc-toolkit )



On 14-02-03 11:21 AM, Sean McBride wrote:
> The function miset_apparent_record_dimension_flag() seems broken.  The second parameter looks like it's meant to return a value by reference, but it's just a plain 'int'.   The clang analyzer rightly warns:
>
> libminc/libsrc2/dimension.c:639:3: Value stored to 'record_flag' is never read
>
> This is public API, should I thought I'd check here before making a patch...


-- 
Best regards,

  Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com