From mishkind at gmail.com  Tue Dec 10 01:26:20 2013
From: mishkind at gmail.com (Mishkin Derakhshan)
Date: Mon, 9 Dec 2013 23:26:20 -0700
Subject: [MINC-users] xdisp compile errors in minc-toolkit on osx 10.7.5
Message-ID: <CAB-GmL2YOMuZ=Kv0kLojATX19csaCmLcv18LMq7vwc8g2nHuNA@mail.gmail.com>

Hi,
I ran into the following error(s) when trying to build from source.

/Users/mishkin/minc-toolkit/xdisp/reshape.c:158:5: error: non-void function
'Crop' should return a value [-Wreturn-type]
    return;

My solution was to open up xdisp/reshape.c and xdisp/tic.c and change
"return;" to "return 0;"
After that everything compiled/installed. Not sure if that was the
"correct" thing to do and if it should be changed in the git repo, but I
thought I would let you all know.
mishkin


[ 96%] Built target olgx
[ 96%] Building C object xdisp/CMakeFiles/xdisp.dir/reshape.c.o
/Users/mishkin/minc-toolkit/xdisp/reshape.c:43:19: warning: assigning to
'char *' from 'byte *' (aka 'unsigned char *') converts between
      pointers to integer types with different sign [-Wpointer-sign]
    theImage->data=&byte_Image[zWidth*zHeight*(bitmap_pad/8)*
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mishkin/minc-toolkit/xdisp/reshape.c:69:4: warning: implicit
declaration of function 'nneighbour_byte_to_byte' is invalid in C99
      [-Wimplicit-function-declaration]
          nneighbour_byte_to_byte ( &tmp_byte[zWidth*zHeight*i], zWidth,
zHeight,
          ^
/Users/mishkin/minc-toolkit/xdisp/reshape.c:91:19: warning: assigning to
'char *' from 'byte *' (aka 'unsigned char *') converts between
      pointers to integer types with different sign [-Wpointer-sign]
    theImage->data=&byte_Image[(bitmap_pad/8)*w*h*
                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mishkin/minc-toolkit/xdisp/reshape.c:122:1: warning: control reaches
end of non-void function [-Wreturn-type]
}
^
/Users/mishkin/minc-toolkit/xdisp/reshape.c:147:1: warning: control reaches
end of non-void function [-Wreturn-type]
}
^
/Users/mishkin/minc-toolkit/xdisp/reshape.c:158:5: error: non-void function
'Crop' should return a value [-Wreturn-type]
    return;
    ^
/Users/mishkin/minc-toolkit/xdisp/reshape.c:233:18: warning: assigning to
'char *' from 'byte *' (aka 'unsigned char *') converts between
      pointers to integer types with different sign [-Wpointer-sign]
  theImage->data = &byte_Image[(bitmap_pad/8)*zWidth*zHeight*
                 ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/mishkin/minc-toolkit/xdisp/reshape.c:463:5: error: non-void function
'Reorient_Volume' should return a value [-Wreturn-type]
    return;
    ^
6 warnings and 2 errors generated.
make[2]: *** [xdisp/CMakeFiles/xdisp.dir/reshape.c.o] Error 1
make[1]: *** [xdisp/CMakeFiles/xdisp.dir/all] Error 2
make: *** [all] Error 2

From a.janke at gmail.com  Tue Dec 10 06:19:06 2013
From: a.janke at gmail.com (Andrew Janke)
Date: Tue, 10 Dec 2013 21:19:06 +1000
Subject: [MINC-users] xdisp compile errors in minc-toolkit on osx 10.7.5
In-Reply-To: <CAB-GmL2YOMuZ=Kv0kLojATX19csaCmLcv18LMq7vwc8g2nHuNA@mail.gmail.com>
References: <CAB-GmL2YOMuZ=Kv0kLojATX19csaCmLcv18LMq7vwc8g2nHuNA@mail.gmail.com>
Message-ID: <CAG0CB22aTnkhEc6wp2zogMGsc9Dt1wkpocQpB7htUa-vmLYNog@mail.gmail.com>

Hi Mishkin,

Thanks for the report.  Given that returns you are referencing are
after and error fprintf, I would guess that the return code should be
1 not 0. Of course if the error codes of these functions aren't
checked when they are called then yes, you can set them to whatever
you like!

Vladimir, I have made these commits in the develop tree.

   https://github.com/BIC-MNI/xdisp/commit/36d40cab3d4107d191ae17835e3b1e1e59916347
   https://github.com/BIC-MNI/xdisp/commit/db25f0471af6c9c93dcb866c5bc3506d9b02d330


a


On 10 December 2013 16:26, Mishkin Derakhshan <mishkind at gmail.com> wrote:
> I ran into the following error(s) when trying to build from source.
>
> /Users/mishkin/minc-toolkit/xdisp/reshape.c:158:5: error: non-void function
> 'Crop' should return a value [-Wreturn-type]
>     return;
>
> My solution was to open up xdisp/reshape.c and xdisp/tic.c and change
> "return;" to "return 0;"
> After that everything compiled/installed. Not sure if that was the
> "correct" thing to do and if it should be changed in the git repo, but I
> thought I would let you all know.

From vladimir.fonov at gmail.com  Thu Dec 12 15:42:52 2013
From: vladimir.fonov at gmail.com (Vladimir S. FONOV)
Date: Thu, 12 Dec 2013 15:42:52 -0500
Subject: [MINC-users] minc-toolkit version 1.0.01 released
Message-ID: <52AA1FCC.7050108@gmail.com>

Hello Everybody,

I have released a new version of minc-toolkit , it is 1.0.01 the binary 
versions for Ubuntu, Debian, CentOS and MacOS X as well as source code 
is available at

http://www.bic.mni.mcgill.ca/ServicesSoftware/ServicesSoftwareMincToolKit

This version includes xdisp and various bug fixes of many standard tools 
like minctracc. Also, this version includes latest version of libminc 
which now adds ability to read MINC1 files using MINC2 api (by 
converting file on-the fly). So, RMINC compiled with this version of 
libminc should support reading of MINC1 files.

This version should run consistently at least on 64 bit platforms (i.e 
MacOS X, Ubuntu , Debian and Centos produce the same results).

I have also released new version of minc-toolkit-testsuite, version 
0.1.3 which can be used to validate that minc-toolkit installation is 
working properly (only on 64bit platforms).

-- 
Best regards,

  Vladimir S. FONOV ~ vladimir.fonov <at> gmail.com

From andrew at biospective.com  Tue Dec 31 09:56:01 2013
From: andrew at biospective.com (Andrew Wood)
Date: Tue, 31 Dec 2013 09:56:01 -0500
Subject: [MINC-users] BIC Objects and Python
Message-ID: <CABApf9EacDjhqgQvofXty2003KcktugeEwtxxApCzci53Ndmdw@mail.gmail.com>

Hi all,

I was wondering if anyone has written something yet that can read/write BIC
object files from Python.

Thanks,
Andrew