[MINC-development] max_buffer_size_in_kb

[Andrew Janke]

OK, so the approach will be to modify this:

   https://github.com/andrewjanke/minc/blob/master/libsrc/voxel_loop.c#L2690

And any of the various programs that use voxel_loop argument defaults?
Or if we take the ENV approach then we'll have to set the program
defaults to "undef" or something so that an ENV var can take
precedence.

For now I think it will be simpler (for me) to skip the ENV var and
just increase the default. Anyone have any particular preference for
how big? In my case I usually just set it to "massive", but I suspect
this is not the best idea...

My initial thought is to set it to about 200MB (~50x the current).
1024*4*64 = 262144kb

Thoughts?


a


On 11 August 2011 22:33, Alex Zijdenbos <zijdenbos at gmail.com> wrote:
> I'm all for this. I recently had a case for which processing time went
> from around 7 hrs to 10 mins or so by changing the buffer size. An ENV
> var approach would be good, but regardless I think we should change
> the default as well, it seems rather outdated.
>
> -- A
>
> On Thu, Aug 11, 2011 at 4:42 AM,  <jcupitt at gmail.com> wrote:
>> On 11 August 2011 08:03, Andrew Janke <a.janke at gmail.com> wrote:
>>> Would anyone be against me upping the default limit (4MB in most tools)?
>>>
>>> Perhaps we should take an ENV var approach?
>>
>> Sounds good.
>>
>> For what it's worth, most libraries seem to use both env vars and
>> command-line switches, so you could have:
>>
>> $ minc-process file.mnc
>>
>> will use the default buffer size
>>
>> $ MINC_BUFFER=64m minc-process file.mnc
>>
>> will use a 64mb buffer and
>>
>> $ MINC_BUFFER=64m minc-process --minc-buffer=8m file.mnc
>>
>> will use a 8mb buffer (command-line switches always override env
>> vars). The idea is that the env var sets the default, the switch sets
>> the value for this invocation.
>>
>> John
>> _______________________________________________
>> MINC-development mailing list
>> MINC-development at bic.mni.mcgill.ca
>> http://www.bic.mni.mcgill.ca/mailman/listinfo/minc-development
>>
>>
> _______________________________________________
> MINC-development mailing list
> MINC-development at bic.mni.mcgill.ca
> http://www.bic.mni.mcgill.ca/mailman/listinfo/minc-development
>