[MINC-development] volume_stats/mincstats???

[Andrew Janke]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

---2107239605-2105447743-1060748909=:2664541
Content-Type: TEXT/PLAIN; charset=US-ASCII

On Tue, 12 Aug 2003, Robert VINCENT wrote:

> I've taken a look at this.  If I follow Peter's comments and the program's
> logic, it looks as though the following line needs to be added to
> mincstats.c:
>
> *** 618,623 ****
> --- 618,624 ----
>               else
>                  stats->median = ((double)median_bin + (0.5 - cdf[median_bin])
>                                   * pdf[median_bin + 1]) *  hist_sep;
> + 	    stats->median += hist_centre[0];
>
>               stats->majority = hist_centre[majority_bin];
>               stats->biModalT = hist_centre[bimodalt_bin];
>
> Does this look correct?

>From what I can tell yes.  I have a slightly more extensive diff (attached) of
which the only change of consequence (I hope!) is the one above.  Once I get a
go-ahead WRT indenting I'll commit extensive indenting changes + the change
above to CVS.

Howver on this matter, those comparing mincstats and volume_stats should note
that the output at least of histogramming is never going to be identical, this
comes down to a fundamental "algorithmic mis-match" between what peter & I and
Alex think the centre of a discrete minc histogram should be and also how many
default bins should be used for a discrete minc file. :)

In order to more closely replicate the behaviour of volume_stats with mincstats
on a discrete (non float or double) minc file, mincstats should be used as such:

   $ mincstats -discrete_histogram file.mnc

(see the mincstats man page for the gory details of this)

--
Andrew Janke   ( rotor@cmr.uq.edu.au || www.cmr.uq.edu.au/~rotor )
Australia->University of Queensland->Centre for Magnetic Resonance
W: +61 7 3365 4100  ||  H: +61 7 3800 4042  ||  M: +61 4 2138 8581
---2107239605-2105447743-1060748909=:2664541
Content-Type: TEXT/PLAIN; charset=US-ASCII; name=diff
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.SGI.4.53.0308131428290.2664541@twodogs.cmr.uq.edu.au>
Content-Description: 
Content-Disposition: attachment; filename=diff

SW5kZXg6IG1pbmNzdGF0cy5jDQo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQpS
Q1MgZmlsZTogL3NvZnR3YXJlL3NvdXJjZS9taW5jL2N2c3Jvb3QvbWluYy9w
cm9ncy9taW5jc3RhdHMvbWluY3N0YXRzLmMsdg0KcmV0cmlldmluZyByZXZp
c2lvbiAxLjExDQpkaWZmIC11IC1iIC1CIC1yMS4xMSBtaW5jc3RhdHMuYw0K
LS0tIG1pbmNzdGF0cy5jIDUgU2VwIDIwMDIgMDA6NDE6NTcgLTAwMDAgICAg
ICAgMS4xMQ0KKysrIG1pbmNzdGF0cy5jIDEzIEF1ZyAyMDAzIDA0OjIwOjIx
IC0wMDAwDQpAQCAtNTcyLDEwICs1NzIsMTAgQEANCiANCiAgICAgICAgICAg
ICBmb3IgKGM9MDsgYyA8IGhpc3RfYmluczsgYysrKSB7DQogICAgICAgICAg
ICAgICAgaGlzdF9jZW50cmVbY10gPSAoYypoaXN0X3NlcCkgKyBoaXN0X3Jh
bmdlWzBdICsgKGhpc3Rfc2VwLzIpOw0KLSAgICAgICAgICAgICAgIHBkZltj
XSA9IChzdGF0cy0+aHZveGVscyA+IDApID8gDQotICAgICAgICAgICAgICAg
ICAgc3RhdHMtPmhpc3RvZ3JhbVtjXS9zdGF0cy0+aHZveGVscyA6IDAuMDsN
Ci0gICAgICAgICAgICAgICBpZiAoYyA9PSAwKSB7IGNkZltjXSA9IHBkZltj
XTsgICAgICAgICAgICB9DQotICAgICAgICAgICAgICAgZWxzZSAgICAgICAg
eyBjZGZbY10gPSBjZGZbYy0xXSArIHBkZltjXTsgfQ0KKyAgICAgICAgICAg
ICAgIA0KKyAgICAgICAgICAgICAgIC8qIFByb2JhYmlsaXR5IGFuZCBDdW11
bGF0aXZlIGRlbnNpdHkgZnVuY3Rpb25zICovDQorICAgICAgICAgICAgICAg
cGRmW2NdID0gKHN0YXRzLT5odm94ZWxzID4gMCkgPw0Kc3RhdHMtPmhpc3Rv
Z3JhbVtjXS9zdGF0cy0+aHZveGVscyA6IDAuMDsNCisgICAgICAgICAgICAg
ICBjZGZbY10gPSAoYyA9PSAwKSA/IHBkZltjXSA6IGNkZltjLTFdICsgcGRm
W2NdOw0KIA0KICAgICAgICAgICAgICAgIC8qIE1ham9yaXR5ICovDQogICAg
ICAgICAgICAgICAgaWYgKHN0YXRzLT5oaXN0b2dyYW1bY10gPiBzdGF0cy0+
aGlzdG9ncmFtW21ham9yaXR5X2Jpbl0pIHsNCkBAIC02MTMsMjEgKzYxMywy
NiBAQA0KICAgICAgICAgICAgIH0NCiAgICAgICAgICANCiAgICAgICAgICAg
ICAvKiBtZWRpYW4gKi8NCi0gICAgICAgICAgICBpZiAobWVkaWFuX2JpbiA9
PSAwKQ0KKyAgICAgICAgICAgIGlmIChtZWRpYW5fYmluID09IDApew0KICAg
ICAgICAgICAgICAgIHN0YXRzLT5tZWRpYW4gPSAwLjUgKiBwZGZbbWVkaWFu
X2Jpbl0gKiAgaGlzdF9zZXA7DQotICAgICAgICAgICAgZWxzZQ0KKyAgICAg
ICAgICAgICAgIH0NCisgICAgICAgICAgICBlbHNlew0KICAgICAgICAgICAg
ICAgIHN0YXRzLT5tZWRpYW4gPSAoKGRvdWJsZSltZWRpYW5fYmluICsgKDAu
NSAtIGNkZlttZWRpYW5fYmluXSkgDQogICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAqIHBkZlttZWRpYW5fYmluICsgMV0pICogIGhpc3Rfc2Vw
Ow0KKyAgICAgICAgICAgICAgIH0NCisgICAgICAgICAgICBzdGF0cy0+bWVk
aWFuICs9IGhpc3RfY2VudHJlWzBdOw0KICAgICAgIA0KICAgICAgICAgICAg
IHN0YXRzLT5tYWpvcml0eSA9IGhpc3RfY2VudHJlW21ham9yaXR5X2Jpbl07
DQogICAgICAgICAgICAgc3RhdHMtPmJpTW9kYWxUID0gaGlzdF9jZW50cmVb
Ymltb2RhbHRfYmluXTsNCiAgICAgICANCiAgICAgICAgICAgICAvKiBwY3Qg
VGhyZXNob2xkICovDQotICAgICAgICAgICAgaWYgKHBjdHRfYmluID09IDAp
DQorICAgICAgICAgICAgaWYgKHBjdHRfYmluID09IDApew0KICAgICAgICAg
ICAgICAgIHN0YXRzLT5wY3RfVCA9IHBjdFQgKiBwZGZbcGN0dF9iaW5dICog
IGhpc3Rfc2VwOw0KLSAgICAgICAgICAgIGVsc2UNCisgICAgICAgICAgICAg
ICB9DQorICAgICAgICAgICAgZWxzZXsNCiAgICAgICAgICAgICAgICBzdGF0
cy0+cGN0X1QgPSAoKGRvdWJsZSlwY3R0X2JpbiArIChwY3RUIC0gY2RmW3Bj
dHRfYmluXSkgDQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICog
cGRmW3BjdHRfYmluICsgMV0pICogIGhpc3Rfc2VwOw0KKyAgICAgICAgICAg
ICAgIH0NCiAgICAgICANCiAgICAgICAgICAgICAvKiBvdXRwdXQgdGhlIGhp
c3RvZ3JhbSAqLw0KICAgICAgICAgICAgIGlmIChoaXN0X2ZpbGUgIT0gTlVM
TCkgew0KQEAgLTcyNCw4ICs3MjksOSBAQA0KICAgIH0gICAvKiBFbmQgb2Yg
bG9vcCBvdmVyIHJhbmdlcyAqLw0KIA0KICAgIC8qIENsb3NlIHRoZSBoaXN0
b2dyYW0gZmlsZSAqLw0KLSAgIGlmIChGUCAhPSBOVUxMKQ0KKyAgIGlmIChG
UCAhPSBOVUxMKXsNCiAgICAgICh2b2lkKSBmY2xvc2UoRlApOw0KKyAgICAg
fQ0KIA0KICAgIC8qIEZyZWUgdGhpbmdzIHVwICovDQogICAgZm9yIChpcmFu
Z2U9MDsgaXJhbmdlIDwgbnVtX3JhbmdlczsgaXJhbmdlKyspIHsNCkBAIC04
MzYsNyArODQyLDkgQEANCiAgICAgICBpZiAoSGlzdCAmJiAodmFsdWUgPj0g
aGlzdF9yYW5nZVswXSkgJiYgKHZhbHVlIDw9IGhpc3RfcmFuZ2VbMV0pKSB7
DQogICAgICAgICAgLypsb3dlciBsaW1pdCA8PSB2YWx1ZSA8IHVwcGVyIGxp
bWl0ICovDQogICAgICAgICAgaGlzdF9pbmRleCA9IChpbnQpZmxvb3IoKHZh
bHVlIC0gaGlzdF9yYW5nZVswXSkvaGlzdF9zZXApOw0KLSAgICAgICAgIGlm
IChoaXN0X2luZGV4ID49IGhpc3RfYmlucykgaGlzdF9pbmRleCA9IGhpc3Rf
Ymlucy0xOw0KKyAgICAgICAgIGlmIChoaXN0X2luZGV4ID49IGhpc3RfYmlu
cyl7DQorICAgICAgICAgICAgaGlzdF9pbmRleCA9IGhpc3RfYmlucy0xOw0K
KyAgICAgICAgICAgIH0NCiAgICAgICAgICBzdGF0cy0+aGlzdG9ncmFtW2hp
c3RfaW5kZXhdKys7DQogICAgICAgICAgc3RhdHMtPmh2b3hlbHMrKzsNCiAg
ICAgICB9DQoNCg==

---2107239605-2105447743-1060748909=:2664541--