[MINC-development] Re: reviews are a lottery

Andrew Janke minc-development@bic.mni.mcgill.ca
Tue, 3 Dec 2002 18:07:09 +1000


On Mon, 2 Dec 2002, Steve ROBBINS wrote:

> By the by, I really like mincpik -- it beats my scripts with
> hardcoded ICBM image sizes.
>
> But I'm partial to the hotmetal colourmap.  And sometimes other
> colourmaps, so what do you think about this patch?  It lets me
> do things like
>
>     mincpik -lookup -hotmetal foo.mnc bar.png
> or  mincpik -lookup '-discrete -lookup red-blue.lut' foo.mnc bar.png

The patch looks fine, I have added major portions of it to the current version
of mincpik in CVS.  /s/s/minc_dev/mincpik

I have been working on a much simplified version of minpik (I wrote most of that
perl yonks ago when I knew not much of MINC, as such most of it was a perlerised
version of mincview)

I've added a few extra bits, WRT handling of the -image_range option when a
lookup-table is specified, I assume this is what you'd expect such a combination
of options to do..  ie:

   $ mincpik -lookup -hotmetal -image_range 0 100 foo.mnc | display -

passed a -range option to minclookup. without a -lookup option, mincextract
handles this option.  Although now that I think about it a bit more it'd be far
simpler to let mincreshape handle this option...  Hrm.. next time perhaps..
it'll make for shorter code!

Grrgh, just when I thought I was finished.. :)

Let us know if this version behaves itself as you think it should, if not I'm
happy to make changes to bring it inline with whatever you have already.




--
Andrew Janke   ( rotor@cmr.uq.edu.au || www.cmr.uq.edu.au/~rotor )
Australia->University of Queensland->Centre for Magnetic Resonance
Work: +61 7 3365 4100 || Home: +61 7 3800 4042